[
https://issues.apache.org/jira/browse/PHOENIX-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530857#comment-17530857
]
ASF GitHub Bot commented on PHOENIX-6699:
-----------------------------------------
stoty commented on PR #1431:
URL: https://github.com/apache/phoenix/pull/1431#issuecomment-1115151165
@joshelser @gjacoby126
Now I was able to test a real cluster with this patch.
The phoenix metrics are added to the HBase metrics just fine, no change.
`{
"name": "Hadoop:service=HBase,name=RegionServer,sub=PhoenixIndexer",
"modelerType": "RegionServer,sub=PhoenixIndexer",
"tag.Context": "phoenix",
"tag.Hostname": "stoty-3.stoty.root.hwx.site",
"IndexPrepareTime_num_ops": 2,
"IndexPrepareTime_min": 0,
"IndexPrepareTime_max": 0,`
> Phoenix metrics overwriting DefaultMetricsSystem in RegionServers
> -----------------------------------------------------------------
>
> Key: PHOENIX-6699
> URL: https://issues.apache.org/jira/browse/PHOENIX-6699
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.2.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> There is a race condition in the Hbase and Phoenix metrics handling.
> Hbase metrics is supposed to run in the daemon processes, while Phoenix
> metrics is supposed to run on the phoenix client side.
> On an RS both HBase and Phoenix tries to register its metrics implementation
> into DefaultMetricsSystem.
>
> On the happy path, when Phoenix tries to register its metrics on the RS, it
> won't have any effect, because HBase has already registered an active Metrics
> implementation.
> However, JmxCacheBuster stops the Hbase metrics system for ~500ms every five
> seconds, and if Phoenix tries to initialize its metrics in this period, then
> it will succeed in initializing its Metrics object, and will overwrite
> theDefaultMetricsSystem object initialized by HBase.
> This disables the HBase metrics system for the RS process.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
