stoty commented on code in PR #1434:
URL: https://github.com/apache/phoenix/pull/1434#discussion_r867673849
##########
pom.xml:
##########
@@ -121,8 +121,8 @@
<stream.version>2.9.5</stream.version>
<i18n-util.version>1.0.4</i18n-util.version>
<guice.version>4.0</guice.version>
- <zookeeper.version>3.4.14</zookeeper.version>
- <curator.version>4.0.0</curator.version>
+ <zookeeper.version>3.5.7</zookeeper.version>
+ <curator.version>4.3.0</curator.version>
Review Comment:
HBase uses 4.2.
While it's probably OK to use a newer version, if there is no particular
reason to use 4.3, it's better to stick with the version HBase uses.
##########
pom.xml:
##########
@@ -121,8 +121,8 @@
<stream.version>2.9.5</stream.version>
<i18n-util.version>1.0.4</i18n-util.version>
<guice.version>4.0</guice.version>
- <zookeeper.version>3.4.14</zookeeper.version>
- <curator.version>4.0.0</curator.version>
+ <zookeeper.version>3.5.7</zookeeper.version>
Review Comment:
Please remove the corresponding overrides from the profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
