[
https://issues.apache.org/jira/browse/PHOENIX-6687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535064#comment-17535064
]
ASF GitHub Bot commented on PHOENIX-6687:
-----------------------------------------
gjacoby126 commented on code in PR #1440:
URL: https://github.com/apache/phoenix/pull/1440#discussion_r870636915
##########
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -223,11 +223,13 @@ public class QueryServicesOptions {
* HConstants#HIGH_QOS is the max we will see to a standard table. We go
higher to differentiate
* and give some room for things in the middle
*/
+ public static final int DEFAULT_SERVER_SIDE_PRIORITY = 500;
Review Comment:
@jpisaac - I'm curious how you determined this priority (much less than
metadata, which is very similar, and less than indexes)
##########
phoenix-core/src/main/java/org/apache/hadoop/hbase/ipc/controller/ServerSideRPCControllerFactory.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.ipc.controller;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * {@link RpcControllerFactory} that should only be used when
+ * making server-server remote RPCs to the region servers hosting Phoenix
SYSTEM tables.
Review Comment:
@jpisaac - if this is only for server-to-server RPCs to system tables, how
is this different from the existing metadata pool? I thought that's what that
was already for?
##########
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -223,11 +223,13 @@ public class QueryServicesOptions {
* HConstants#HIGH_QOS is the max we will see to a standard table. We go
higher to differentiate
* and give some room for things in the middle
*/
+ public static final int DEFAULT_SERVER_SIDE_PRIORITY = 500;
public static final int DEFAULT_INDEX_PRIORITY = 1000;
public static final int DEFAULT_METADATA_PRIORITY = 2000;
public static final boolean DEFAULT_ALLOW_LOCAL_INDEX = true;
public static final int DEFAULT_INDEX_HANDLER_COUNT = 30;
public static final int DEFAULT_METADATA_HANDLER_COUNT = 30;
+ public static final int DEFAULT_SERVERSIDE_HANDLER_COUNT = 30;
Review Comment:
is this the right default? (Are the current defaults the right defaults?)
Will we expect a cluster to have approximately the same load of RS->index,
metadata, and RS->Syscat/Link calls?
> The region server hosting the SYSTEM.CATALOG fails to serve any metadata
> requests as default handler pool threads are exhausted.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6687
> URL: https://issues.apache.org/jira/browse/PHOENIX-6687
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 5.1.1, 4.16.1, 5.2.0, 5.1.2
> Reporter: Jacob Isaac
> Assignee: Jacob Isaac
> Priority: Major
> Fix For: 4.17.0, 5.2.0
>
> Attachments: stacktraces.txt
>
>
> When SYSTEM.CATALOG region server is restarted and the server is experiencing
> heavy metadata call volume.
> The stack traces indicate that all the default handler pool threads are
> waiting for the CQSI.init thread to finish initializing.
> The CQSI.init thread itself cannot proceed since it cannot complete the
> second RPC call
> (org.apache.phoenix.query.ConnectionQueryServicesImpl.checkClientServerCompatibility)
> due to thread starvation.
> For e.g
> The following
> [code|https://github.com/apache/phoenix/blob/3cff97087d79b85e282fca4ac69ddf499fb1f40f/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L661]
> turned the getTable(..) into needing an additional server-to-server RPC call
> when initializing a PhoenixConnection (CQSI.init) for the first time on the
> JVM.
> It is well-known that server-to-server RPC calls are prone to deadlocking due
> to thread pool exhaustion.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
