[
https://issues.apache.org/jira/browse/PHOENIX-6688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535066#comment-17535066
]
ASF GitHub Bot commented on PHOENIX-6688:
-----------------------------------------
gjacoby126 commented on code in PR #1439:
URL: https://github.com/apache/phoenix/pull/1439#discussion_r870641315
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java:
##########
@@ -357,11 +379,29 @@ public void testMoveParentChildLinks() throws Exception {
phxMetaConn.setRunningUpgrade(true);
// create the parent-> child links in SYSTEM.CATALOG
UpgradeUtil.addParentToChildLinks(phxMetaConn);
+
+ // Increase the timeouts so that the scan queries during
moveOrCopyChildLinks do not timeout on large syscat's
+ Map<String, String> options = new HashMap<>();
+ options.put(HConstants.HBASE_RPC_TIMEOUT_KEY,
Integer.toString(DEFAULT_TIMEOUT_DURING_UPGRADE_MS));
+ options.put(HConstants.HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD,
Integer.toString(DEFAULT_TIMEOUT_DURING_UPGRADE_MS));
+ String clientPort =
getUtility().getConfiguration().get(QueryServices.ZOOKEEPER_PORT_ATTRIB);
+
+ String localQuorum = String.format("localhost:%s", clientPort);
Review Comment:
nit: can't you get the quorum from the config?
> Upgrade to phoenix 4.16 metadata upgrade fails when SYSCAT has large number
> of tenant views
> -------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6688
> URL: https://issues.apache.org/jira/browse/PHOENIX-6688
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.16.1, 4.17.0, 5.2.0
> Reporter: Jacob Isaac
> Assignee: Jacob Isaac
> Priority: Major
>
> Caused by: org.apache.phoenix.schema.MaxMutationSizeExceededException: ERROR
> 729 (LIM01): MutationState size is bigger than maximum allowed number of
> rows, try upserting rows in smaller batches or using autocommit on for
> deletes.
> at
> org.apache.phoenix.exception.SQLExceptionCode$21.newException(SQLExceptionCode.java:526)
> at
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:228)
> at
> org.apache.phoenix.util.ServerUtil.parseRemoteException(ServerUtil.java:191)
> at
> org.apache.phoenix.util.ServerUtil.parseServerExceptionOrNull(ServerUtil.java:175)
> at
> org.apache.phoenix.util.ServerUtil.parseServerException(ServerUtil.java:142)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1341)
> at
> org.apache.phoenix.iterate.BaseResultIterators.getIterators(BaseResultIterators.java:1280)
> at
> org.apache.phoenix.iterate.RoundRobinResultIterator.getIterators(RoundRobinResultIterator.java:187)
> at
> org.apache.phoenix.iterate.RoundRobinResultIterator.next(RoundRobinResultIterator.java:93)
> at
> org.apache.phoenix.compile.UpsertCompiler$ClientUpsertSelectMutationPlan.execute(UpsertCompiler.java:1409)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:414)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:396)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:395)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:383)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1885)
> at
> org.apache.phoenix.util.UpgradeUtil.moveChildLinks(UpgradeUtil.java:1181)
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemChildLink(ConnectionQueryServicesImpl.java:4055)
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeOtherSystemTablesIfRequired(ConnectionQueryServicesImpl.java:4033)
> at
> org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTables(ConnectionQueryServicesImpl.java:3958)
> at
> org.apache.phoenix.query.DelegateConnectionQueryServices.upgradeSystemTables(DelegateConnectionQueryServices.java:362)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableExecuteUpgradeStatement$1.execute(PhoenixStatement.java:1445)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:414)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:396)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:395)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:383)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeUpdate(PhoenixStatement.java:1866)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
