[
https://issues.apache.org/jira/browse/PHOENIX-6719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545015#comment-17545015
]
ASF GitHub Bot commented on PHOENIX-6719:
-----------------------------------------
gokceni commented on PR #1448:
URL: https://github.com/apache/phoenix/pull/1448#issuecomment-1143850089
LGTM +1 @gjacoby126
There seems to be a unit test failure. Not sure if it is related
> Duplicate Salt Columns in Schema Registry after ALTER
> -----------------------------------------------------
>
> Key: PHOENIX-6719
> URL: https://issues.apache.org/jira/browse/PHOENIX-6719
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.2.0
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.2.0
>
>
> When a table or view is change-detection enabled, we have to update the
> schema registry each time the schema is ALTERed. This is done by calculating
> the old PTable and applying the changed metadata edits to create a new
> PTable, which gets exported to the schema registry.
> There's a bug in this calculation logic for salted tables, where the virtual
> salt column is on the old PTable, but gets added by the Builder logic of the
> new PTable. The result is an incorrect PTable (and schema) with an extra salt
> column.
> I discovered this while testing on a draft of PHOENIX-5517.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
