[
https://issues.apache.org/jira/browse/PHOENIX-6694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545223#comment-17545223
]
ASF GitHub Bot commented on PHOENIX-6694:
-----------------------------------------
stoty commented on PR #80:
URL:
https://github.com/apache/phoenix-connectors/pull/80#issuecomment-1144321121
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 14m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 25m 22s | master passed |
| +1 :green_heart: | compile | 2m 29s | master passed |
| +1 :green_heart: | checkstyle | 0m 28s | master passed |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 3m 5s | phoenix-spark-base in master has 40
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 2s | phoenix5-spark3 in master has 22 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 23m 16s | the patch passed |
| +1 :green_heart: | compile | 2m 29s | the patch passed |
| +1 :green_heart: | javac | 2m 29s | the patch passed |
| -1 :x: | checkstyle | 0m 16s | phoenix-spark-base: The patch
generated 21 new + 128 unchanged - 9 fixed = 149 total (was 137) |
| -1 :x: | checkstyle | 0m 13s | phoenix5-spark3: The patch generated
15 new + 122 unchanged - 5 fixed = 137 total (was 127) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 48s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 50m 13s | phoenix-spark-base in the patch failed. |
| +1 :green_heart: | unit | 0m 56s | phoenix5-spark3 in the patch
passed. |
| -1 :x: | asflicense | 0m 21s | The patch generated 2 ASF License
warnings. |
| | | 137m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/80 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle |
| uname | Linux 61a201f09b53 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 9ed127f |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-spark-base.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/artifact/yetus-general-check/output/patch-unit-phoenix-spark-base.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 1834 (vs. ulimit of 30000) |
| modules | C: phoenix-spark-base phoenix5-spark3 U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-80/2/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Avoid unnecessary calls of fetching table meta data to region servers holding
> the system tables in batch oriented jobs in spark or hive otherwise those RS
> become hotspot
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6694
> URL: https://issues.apache.org/jira/browse/PHOENIX-6694
> Project: Phoenix
> Issue Type: Task
> Components: hive-connector, spark-connector
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
>
> Currently we are preparing the query plan in both data source and partition
> readers which is creating new connection in each worker and job
> initialisation which unnecessarily touch basing all both system catalog
> table, system stats table as well as meta. When there are jobs with millions
> of parallel workers hotspot the region servers holding the meta and system
> catalog as well system stats table. So if we share the same query plan
> between the workers which can avoid the hotspot.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
