chrajeshbabu commented on PR #1437: URL: https://github.com/apache/phoenix/pull/1437#issuecomment-1145202122
> > > Skipping all the upgrade stuff and safety checks is fine, however AFAICT this also skips initialization the CQSI global _connection_ object, and updating _GLOBAL_QUERY_SERVICES_COUNTER_. > > > Are you sure that won't cause problems ? > > > > > > Am double checking it @stoty. We can move the checking the config after hbase connection creation if that didn't work. > > Yes, I think that would be a better idea. Simply opening an HBase connection is probably not too expensive. @stoty moved the config check post hbase connection opening and made the test case more realistic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
