[
https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556557#comment-17556557
]
Geoffrey Jacoby commented on PHOENIX-6085:
------------------------------------------
I'm going to mark the Fix Version for the next version since this doesn't seem
to be urgent based on the earlier conversation, but if anyone wants to take
this up please feel free to move it back if/when the patch is rebased.
> Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the
> upgrade path
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-6085
> URL: https://issues.apache.org/jira/browse/PHOENIX-6085
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Richárd Antal
> Priority: Minor
> Labels: phoenix-hardening, quality-improvement
> Fix For: 4.17.0, 5.2.0
>
> Attachments: PHOENIX-6085.4.x.v1.patch, PHOENIX-6085.master.v1.patch
>
>
> We already make this call inside
> [CQSI.acquireUpgradeMutex()|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4220]
> and then call writeMutexCell() which calls this again
> [here|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4244].
>
> We should move this to inside writeMutexCell() itself and throw
> UpgradeInProgressException if required there to avoid unnecessary expensive
> HBase admin API calls.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
