richardantal commented on code in PR #95:
URL: https://github.com/apache/phoenix-queryserver/pull/95#discussion_r902434901
##########
python-phoenixdb/requirements.txt:
##########
@@ -16,4 +16,4 @@
# specific language governing permissions and limitations
# under the License.
#
-# requirements are defined in setup.py
+# requirements are defined in setup.py
Review Comment:
I am not sure if it is the right direction to have an empty requirements.txt
##########
python-phoenixdb/requirements.txt:
##########
@@ -16,4 +16,4 @@
# specific language governing permissions and limitations
# under the License.
#
-# requirements are defined in setup.py
+# requirements are defined in setup.py
Review Comment:
But if we go this way, `pip install -r requirements.txt` doesn't make any
sense in the README
##########
python-phoenixdb/README.rst:
##########
@@ -92,7 +92,7 @@ various Phoenix-specific features. In order to run the test
suite, you need a
working Phoenix database and set the ``PHOENIXDB_TEST_DB_URL`` environment
variable::
export PHOENIXDB_TEST_DB_URL='http://localhost:8765/'
- nosetests
+ tox
Review Comment:
It is probably related to my local config, but it doesn't work for me
locally, Does it work for you?
I think it is stuck after running `phoenixdb/tests/test_db.py s.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
