[jira] [Commented] (PHOENIX-5686) MetaDataUtil local index methods return incorrect results

[Geoffrey Jacoby (Jira)]

Title: Message Title

Geoffrey Jacoby commented on PHOENIX-5686   Re: MetaDataUtil local index methods return incorrect results There's some additional cleanup in related methods: getLocalIndexPhysicalName and getLocalIndexTableName are also incorrect. Local indexes are stored in a special column family in the physical HBase table that holds the base table they index; the physical name should be the same as the base table's physical name. A related change necessary to this is in UpgradeUtil where these MetaDataUtil methods are incorrectly used to try to do extra logic when turning on namespace mapping for Phoenix schemas; I think much of that logic can be removed or at least grealty simplified. This, from UpgradeUtil:2416, is incorrect: if (MetaDataUtil.isLocalIndex(srcTableName)) { LOGGER.info(String.format("local index '%s' found with physical hbase table name ''..", index.getName(), srcTableName)); destTableName = Bytes .toString(MetaDataUtil.getLocalIndexPhysicalName( newPhysicalTablename.getBytes(StandardCharsets.UTF_8))); // update parent_table property in local index table descriptor conn.createStatement() .execute(String.format("ALTER TABLE %s set " + MetaDataUtil.PARENT_TABLE_KEY + "='%s'", phoenixTableName, table.getPhysicalName())); } Add Comment   This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)