tkhurana commented on code in PR #1470:
URL: https://github.com/apache/phoenix/pull/1470#discussion_r928008986
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -2877,8 +2877,12 @@ public boolean isViewReferenced() {
Collections.reverse(columnMetadata);
tableMetaData.addAll(columnMetadata);
String dataTableName = parent == null || tableType ==
PTableType.VIEW ? null : parent.getTableName().getString();
- PIndexState defaultCreateState =
PIndexState.valueOf(connection.getQueryServices().getConfiguration().
- get(INDEX_CREATE_DEFAULT_STATE,
QueryServicesOptions.DEFAULT_CREATE_INDEX_STATE));
+ PIndexState defaultCreateState;
+ String defaultCreateStateString =
connection.getClientInfo(INDEX_CREATE_DEFAULT_STATE);
+ if (defaultCreateStateString == null) defaultCreateState =
PIndexState.valueOf(connection.getQueryServices().getConfiguration().
Review Comment:
Nit: We put braces for if even if single statement in if-else block and the
statements inside are on a separate line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]