[ 
https://issues.apache.org/jira/browse/PHOENIX-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577481#comment-17577481
 ] 

Andrew Kyle Purtell edited comment on PHOENIX-6627 at 8/9/22 3:22 PM:
----------------------------------------------------------------------

{quote}
I agree on keeping (but preferable renaming) the enum value.
{quote}
It cannot be renamed, or existing downstream code will fail to compile. If that 
is not a concern then yeah the ordinal stored into syscat would not change so 
that aspect of the change would be compatible.

{quote} 
Come to think of it, we cannot just remove the Tephra coprocessor, we MUST keep 
it, otherwise the RS is just going to fail to start up after an upgrade.
{quote}

Release notes would need to insist that any Tephra based transactional table 
that is deployed must be ALTERered to be non-transactional first, this is a 
must in any case, which would delete the coprocessor name from the list. 

However to be safe a no-op coprocessor with the same class name can be kept in 
place so if it is still in the table coprocessor list it will not fail to load.


was (Author: apurtell):
{quote}
I agree on keeping (but preferable renaming) the enum value.
{quote}
It cannot be renamed, or existing code will fail to compile. 

{quote} 
Come to think of it, we cannot just remove the Tephra coprocessor, we MUST keep 
it, otherwise the RS is just going to fail to start up after an upgrade.
{quote}

Release notes would need to insist that any Tephra based transactional table 
that is deployed must be ALTERered to be non-transactional first, this is a 
must in any case, which would delete the coprocessor name from the list. 

However to be safe a no-op coprocessor with the same class name can be kept in 
place so if it is still in the table coprocessor list it will not fail to load.

> Remove all references to Tephra from 4.x and master
> ---------------------------------------------------
>
>                 Key: PHOENIX-6627
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6627
>             Project: Phoenix
>          Issue Type: Sub-task
>          Components: 4.x, tephra
>            Reporter: Istvan Toth
>            Assignee: Zsolt Gyulavari
>            Priority: Major
>             Fix For: 5.2.0
>
>
> Removing tephra from the runtime is easy, as it uses the well defind 
> TransactionProvider interfaces.
> Removing Tephra references from all the test cases is a much bigger task.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to