[
https://issues.apache.org/jira/browse/PHOENIX-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580166#comment-17580166
]
ASF GitHub Bot commented on PHOENIX-6771:
-----------------------------------------
stoty commented on PR #85:
URL:
https://github.com/apache/phoenix-connectors/pull/85#issuecomment-1216327539
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | yamllint | 0m 0s | The patch generated 1 new + 1 unchanged
- 3 fixed = 2 total (was 4) |
||| _ Other Tests _ |
| -1 :x: | asflicense | 0m 27s | The patch generated 2 ASF License
warnings. |
| | | 1m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-85/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/85 |
| Optional Tests | dupname asflicense yamllint |
| uname | Linux a45a1f73ed76 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 996fec8 |
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-85/2/artifact/yetus-general-check/output/whitespace-eol.txt
|
| yamllint |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-85/2/artifact/yetus-general-check/output/diff-patch-yamllint.txt
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-85/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-85/2/console
|
| versions | git=2.7.4 maven=3.3.9 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Allow only "squash and merge" from GitHub UI
> --------------------------------------------
>
> Key: PHOENIX-6771
> URL: https://issues.apache.org/jira/browse/PHOENIX-6771
> Project: Phoenix
> Issue Type: Bug
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Github has three possible merging modes from the UI:
> [https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges]
> Of those, we want "squash and merge" 99% of the time, but sometimes other
> methods are chosen, resulting in a less than ideal commit graph.
> This is configurable via .asf.yml :
> https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Mergebuttons
> I propose that we disable the "merge" and "rebase" options for every Phoenix
> repo via the .asf.yml file.
> This only applies to the GitHub Web UI, the other methods can still be used
> via the standard git operations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
