Aarchy commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946647852
##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
- && CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+ && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
With @stoty we came up with the solution to duplicate the FirstOnRowCell
class (and createFirstOnRow function) from PrivateCellUtil to the Omid
codebase. However, this class has several IA.Private base classes. Could it be
derived directly from Cell or are the base classes also necessary in Omid? Or
is there anything we missed in CellUtil to replace the
KeyValueUtil.createFirstOnRow call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
