[ 
https://issues.apache.org/jira/browse/PHOENIX-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582025#comment-17582025
 ] 

ASF GitHub Bot commented on PHOENIX-6751:
-----------------------------------------

jpisaac commented on PR #1492:
URL: https://github.com/apache/phoenix/pull/1492#issuecomment-1221063294

   @gjacoby126 closing this one, As the commit was signed with my SFDC id.
   
   This patch is not in 5.1 branch, so will need to make another for that 
branch, It just seems too confusing, master branch having the patch  + addendum 
and 5.1 branch being just one patch.
   
   Also realized the PR is missing the test annotation here 
   
   
https://github.com/apache/phoenix/pull/1492/files#diff-e26d2c0bba67152839292ee676236eacf2d8d7cc42e9f3b4e5325f50c0a32e2bL1892
   




> Force using range scan vs skip scan when using the IN operator and large 
> number of RVC elements 
> ------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6751
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6751
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0, 5.1.1, 4.16.0, 5.2.0
>            Reporter: Jacob Isaac
>            Assignee: Jacob Isaac
>            Priority: Critical
>             Fix For: 5.2.0, 5.1.3
>
>
> SQL queries using the IN operator using PKs of different SortOrder were 
> failing during the WHERE clause compilation phase and causing OOM issues on 
> the servers when a large number (~50k) of RVC elements were used in the IN 
> operator.
> SQL queries were failing specifically during the skip scan filter generation. 
> The skip scan filter is generated using a list of point key ranges. 
> [ScanRanges.create|https://git.soma.salesforce.com/bigdata-packaging/phoenix/blob/e0737e0ea7ba7501e78fe23c16e7abca27bfd944/phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java#L80]
> The following getPointKeys 
> [code|https://git.soma.salesforce.com/bigdata-packaging/phoenix/blob/e0737e0ea7ba7501e78fe23c16e7abca27bfd944/phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java#L541]
>  uses the KeyRange sets to create a new list of point-keys. When there are a 
> large number of RVC elements the above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to