[ 
https://issues.apache.org/jira/browse/PHOENIX-6774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583657#comment-17583657
 ] 

ASF GitHub Bot commented on PHOENIX-6774:
-----------------------------------------

richardantal commented on code in PR #1491:
URL: https://github.com/apache/phoenix/pull/1491#discussion_r952701222


##########
pom.xml:
##########
@@ -1882,6 +1883,27 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <id>sonar</id>

Review Comment:
   Bit late but this profile should be called as 'codecoverage'
   Or something else but consistent with the readme and most importantly the 
run-coverage.sh file.
   Please create an addendum for this.





> Enable code coverage reporting to SonarQube in Phoenix
> ------------------------------------------------------
>
>                 Key: PHOENIX-6774
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6774
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Dóra Horváth
>            Assignee: Dóra Horváth
>            Priority: Minor
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to