richardantal commented on code in PR #117:
URL: https://github.com/apache/phoenix-omid/pull/117#discussion_r958480217
##########
.gitignore:
##########
@@ -15,6 +15,7 @@ lib/
*.iws
*~
*.swp
+^dev-support/artifacts
Review Comment:
I don't think we need the `^` character
Also I would add `dev-support/work` here too
##########
pom.xml:
##########
@@ -378,6 +378,8 @@
<!-- Exclude config and scripts -->
<exclude>**/dev-utils/*</exclude>
+ <exclude>dev-support/artifacts/**</exclude>
Review Comment:
Also we should exclude this and `dev-support/work/**` folders from
`apache-rat-plugin`
And maybe move those exclusions from a profile to apply globally but that
could be handled as a separate task as it is not related to the scope of this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
