gjacoby126 commented on code in PR #1497:
URL: https://github.com/apache/phoenix/pull/1497#discussion_r969913820
##########
phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java:
##########
@@ -120,7 +122,12 @@ public void testOtherTablesAutoPass() throws Exception {
//Cell is nonsense but we should auto pass because the table name's not
System.Catalog
WAL.Entry entry = new WAL.Entry(new WALKeyImpl(REGION,
TableName.valueOf(TestUtil.ENTITY_HISTORY_TABLE_NAME),
System.currentTimeMillis()), new WALEdit());
- entry.getEdit().add(CellUtil.createCell(Bytes.toBytes("foo")));
+ entry.getEdit().add(
+ ExtendedCellBuilderFactory.create(
Review Comment:
@Aarchy - looks like this change is still remaining to be done.
##########
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java:
##########
@@ -195,7 +196,7 @@ public void write(TableRowkeyPair row, V cell)
// we now have the proper WAL writer. full steam ahead
if (cell.getTimestamp() == HConstants.LATEST_TIMESTAMP) {
- CellUtil.setTimestamp(cell, this.now);
+ PrivateCellUtil.setTimestamp(cell, this.now);
Review Comment:
Looks like this still needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
