[ 
https://issues.apache.org/jira/browse/PHOENIX-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603940#comment-17603940
 ] 

ASF GitHub Bot commented on PHOENIX-6767:
-----------------------------------------

stoty commented on code in PR #1493:
URL: https://github.com/apache/phoenix/pull/1493#discussion_r970446421


##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -549,6 +550,7 @@ private static void assertMetricValue(Metric m, MetricType 
checkType, long compa
         assertSelectQueryTableMetrics(tableName, false, 1, 0, 1, 0, 0, true, 
0, 0, rs);
     }
 
+    @Ignore

Review Comment:
   nit: Can you add coments here ?



##########
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixTableLevelMetricsIT.java:
##########
@@ -549,6 +550,7 @@ private static void assertMetricValue(Metric m, MetricType 
checkType, long compa
         assertSelectQueryTableMetrics(tableName, false, 1, 0, 1, 0, 0, true, 
0, 0, rs);
     }
 
+    @Ignore

Review Comment:
   nit: Can you add comments here ?





> Traversing through all the guideposts to prepare parallel scans is not 
> required for salted tables when the query is point lookup
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6767
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6767
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>             Fix For: 5.2.0
>
>
> Currently even when the query is point lookup on salted table we are 
> traversing through region boundaries or guideposts to create parallel scans 
> which is not required and adding overhead to point lookup queries even we 
> know the exact region or guide post need to be scanned to find the results. 
> When the guide posts are high or number of regions are high leading higher 
> latencies for point lookup query.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to