gjacoby126 commented on code in PR #1506: URL: https://github.com/apache/phoenix/pull/1506#discussion_r983709672
########## phoenix-core/src/it/java/org/apache/phoenix/query/MetaDataCachingIT.java: ########## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.query; + +import org.apache.phoenix.end2end.NeedsOwnMiniClusterTest; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData; +import org.apache.phoenix.schema.*; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.RunUntilFailure; +import org.junit.BeforeClass; +import org.junit.Ignore; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.util.Map; +import java.util.Random; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; + +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +@RunWith(RunUntilFailure.class) +@Category(NeedsOwnMiniClusterTest.class) +public class MetaDataCachingIT extends BaseTest { + + private static final Logger LOGGER = LoggerFactory.getLogger(MetaDataCachingIT.class); + private final Random RAND = new Random(11); + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> props = Maps.newHashMapWithExpectedSize(1); + // We set here a tiny cache to verify that even if the total size of the cache is just enough to hold + // system tables and Phoenix is still functional. Please note the cache weight for system tables is set to Review Comment: nice comment, thanks ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/AppendOnlySchemaIT.java: ########## @@ -324,7 +326,11 @@ public void testValidateAttributes() throws Exception { assertEquals(1000, view.getUpdateCacheFrequency()); } } - + + /* + In PHOENIX-6761, connection level cache is removed so the dropped view will not be found when trying to upsert to it. Review Comment: If the test isn't valid anymore, should it be removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
