[ 
https://issues.apache.org/jira/browse/PHOENIX-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618879#comment-17618879
 ] 

ASF GitHub Bot commented on PHOENIX-6776:
-----------------------------------------

mnpoonia commented on code in PR #1517:
URL: https://github.com/apache/phoenix/pull/1517#discussion_r997017269


##########
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java:
##########
@@ -757,6 +759,7 @@ synchronized public void close() throws SQLException {
             }
             
         } finally {
+            isClosing = false;

Review Comment:
   It looks like we are bitten by some multi threading issue and we are trying 
to reduce the probability of that. @lokiore Is there something that i am 
missing?





> Abort scans of closed connections at ScanningResultIterator
> -----------------------------------------------------------
>
>                 Key: PHOENIX-6776
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6776
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Kadir Ozdemir
>            Assignee: Lokesh Khurana
>            Priority: Major
>
> The server side paging feature introduced by PHOENIX-6211 breaks a scan into 
> timed scan operations on the server side and returns an intermediate result 
> for each operation. This intermediate result could be a valid result or a 
> dummy result. The HBase scans are wrapped by ScanningResultIterator in 
> Phoenix. If the next call on a scan returns a dummy or empty result, 
> ScanningResultIterator ignores this result and call the next method on the 
> scan again. However, if the Phoenix connection is closed, we should abort the 
> scan instead of continuing scanning. This will result in timely abort of 
> scans and release of resources (especially when phoenix.server.page.size.ms 
> is set to a small value, e.g., 5 sec).
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to