virajjasani commented on code in PR #1522:
URL: https://github.com/apache/phoenix/pull/1522#discussion_r1010797507
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -5966,16 +5966,17 @@ public HRegionLocation getTableRegionLocation(byte[]
tableName, byte[] row) thro
* to which specified row belongs to.
*/
int retryCount = 0, maxRetryCount = 1;
- boolean reload =false;
while (true) {
+ TableName table = TableName.valueOf(tableName);
try {
- return
connection.getRegionLocator(TableName.valueOf(tableName)).getRegionLocation(row,
reload);
+ return
connection.getRegionLocator(table).getRegionLocation(row, false);
} catch (org.apache.hadoop.hbase.TableNotFoundException e) {
String fullName = Bytes.toString(tableName);
throw new
TableNotFoundException(SchemaUtil.getSchemaNameFromFullName(fullName),
SchemaUtil.getTableNameFromFullName(fullName));
} catch (IOException e) {
+ LOGGER.error(String.format("Exception encountered in
getTableRegionLocation for " +
+ "table: {}, retryCount: {}", table.getNameAsString(),
retryCount), e);
Review Comment:
same as above
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -725,17 +725,17 @@ public List<HRegionLocation> getAllTableRegions(byte[]
tableName) throws SQLExce
byte[] currentKey = HConstants.EMPTY_START_ROW;
do {
HRegionLocation regionLocation =
((ClusterConnection)connection).getRegionLocation(
- TableName.valueOf(tableName), currentKey, reload);
+ table, currentKey, false);
currentKey = getNextRegionStartKey(regionLocation,
currentKey);
locations.add(regionLocation);
} while (!Bytes.equals(currentKey, HConstants.EMPTY_END_ROW));
return locations;
} catch (org.apache.hadoop.hbase.TableNotFoundException e) {
- String fullName = Bytes.toString(tableName);
- throw new TableNotFoundException(fullName);
+ throw new TableNotFoundException(table.getNameAsString());
} catch (IOException e) {
+ LOGGER.error(String.format("Exception encountered in
getAllTableRegions for " +
+ "table: {}, retryCount: {}", table.getNameAsString(),
retryCount), e);
Review Comment:
nit: `String.format` is redundant
```
LOGGER.error("Exception encountered in getAllTableRegions for " +
"table: {}, retryCount: {}",
table.getNameAsString(), retryCount, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
