[ 
https://issues.apache.org/jira/browse/PHOENIX-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630887#comment-17630887
 ] 

ASF GitHub Bot commented on PHOENIX-6831:
-----------------------------------------

stoty commented on PR #91:
URL: 
https://github.com/apache/phoenix-connectors/pull/91#issuecomment-1308489738

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   5m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  35m 22s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 10s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 16s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  master passed  |
   | +0 :ok: |  spotbugs  |   2m 16s |  phoenix-hive-base in master has 46 
extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  21m 31s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 21s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 21s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 17s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  1s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m 13s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  47m 36s |  phoenix-hive-base in the patch failed.  |
   | -1 :x: |  asflicense  |   0m 13s |  The patch generated 2 ASF License 
warnings.  |
   |  |   | 119m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-91/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/91 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile 
spotbugs hbaseanti checkstyle |
   | uname | Linux 9d77b6a5d744 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 7e2c40f |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-91/1/artifact/yetus-general-check/output/patch-unit-phoenix-hive-base.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-91/1/testReport/
 |
   | asflicense | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-91/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 1760 (vs. ulimit of 30000) |
   | modules | C: phoenix-hive-base U: phoenix-hive-base |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-91/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Remove bogus Ant dependency from hive connector test util
> ---------------------------------------------------------
>
>                 Key: PHOENIX-6831
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6831
>             Project: Phoenix
>          Issue Type: Task
>          Components: connectors, hive-connector
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Minor
>              Labels: test
>
> We're throwing an unchecked Exception from Ant for no discernible reason.
> Replace it with IllegalArgumentException.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to