horvathdora commented on code in PR #112:
URL: 
https://github.com/apache/phoenix-queryserver/pull/112#discussion_r1039623165


##########
pom.xml:
##########
@@ -701,6 +702,13 @@
             <name>!skip.code-coverage</name>
         </property>
       </activation>
+      <properties>
+          <sonar.dynamicAnalysis>reuseReports</sonar.dynamicAnalysis>
+          
<sonar.surefire.reportsPath>${project.build.directory}/surefire-reports</sonar.surefire.reportsPath>
+          <sonar.coverage.jacoco.xmlReportPaths>
+              ${project.build.directory}/site/jacoco/jacoco.xml

Review Comment:
   If I do it like in the phoenix component and aggregate the coverage in the 
assembly module then the phoenix-queryserver-orchestrator module is not 
included in the coverage however I tried to modified the configuration of the 
jacoco and sonar profiles. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to