[ https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646535#comment-17646535 ]
Gourab Taparia commented on PHOENIX-6655: ----------------------------------------- [~tkhurana] [~kadir] [~stoty] Please review the attached PR. Summary : The changes have been made to ensure that the cache on write related properties are set for SYSTEM.SEQUENCE table. The flag is set for both new tables and also existing tables - via the upgrade path. IT have been added for the same, to verify both cases. We also set the index and bloom blocks on write together with data blocks here. > SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true > ----------------------------------------------------------- > > Key: PHOENIX-6655 > URL: https://issues.apache.org/jira/browse/PHOENIX-6655 > Project: Phoenix > Issue Type: Improvement > Reporter: Geoffrey Jacoby > Assignee: Gourab Taparia > Priority: Major > Attachments: Screenshot 2022-11-25 at 4.38.38 PM.png > > > High volume use cases of Phoenix sequences need to write to the same row of > SYSTEM.SEQUENCE very frequently, but each time we write, the block cache that > row is in is invalidated and has to be loaded again. > [~rushabh.shah] was looking at a case in our environment where a sequence was > being used heavily and found lots of time spent reading the HFiles for the > same Get of the sequence row within the SequenceRegionObserver increment > coproc. > [~apurtell] pointed out offline that HColumnDescriptor has a property, > CACHE_DATA_ON_WRITE that keeps caches updated when a value is flushed. This > should help improve contention on sequence increments. -- This message was sent by Atlassian Jira (v8.20.10#820010)