shahrs87 commented on PR #1541: URL: https://github.com/apache/phoenix/pull/1541#issuecomment-1353757979
> When it is transactional tables they consider it as one mutation as a whole. But if we really wanted to get number of deletes that were part of batch we need to fetch it using DELETE_BATCH_FAILED_SIZE instead of MUTATION_BATCH_FAILED_SIZE I think we need to use DELETE_BATCH_FAILED_SIZE, right? That was the reason this JIRA was created in the first place. Am I understanding something wrong? Table being transactional doesn't have to do anything with how many deletes failed in that batch. Both are orthogonal. We tried to delete 4 rows and that failed. So the metric should reflect how many rows we tried to delete and failed. > We should fix the logic for deletes/mixed delete + upsert mutation batch failures. The above line from the JIRA description. I don't understand what the author meant by mixed delete + upsert mutation batch failures. Does he mean if we perform delete and upsert mutation in 1 transaction, it will update the metric just by 1 also? Also what is the behavior if UPSERT SELECT queries are run? @mnpoonia @virajjasani @tkhurana -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
