shahrs87 commented on PR #1541: URL: https://github.com/apache/phoenix/pull/1541#issuecomment-1361683178
> I am bit confused. Chinmay's description on the jira did not have any mention of transactional usecase. > In the conn.commit() path, we get the number of mutations that failed to be committed in the catch block of MutationState.sendMutations() (see [here](https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L1195-L1198)). In the jira description, he added link to the above code.He referred to `getUncommittedStatementIndexes` method which internally updates `uncommittedStatementIndexes` array. The only place where uncommittedStatementIndexes is being updated is `addUncommittedStatementIndexes` which is called from `MutationState#send` method iff table is transactional. See code [here](https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L972). So I assumed that this jira is for transactional table only. @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
