virajjasani commented on code in PR #1541: URL: https://github.com/apache/phoenix/pull/1541#discussion_r1061860574
########## phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationBatchFailedStateMetricIT.java: ########## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.monitoring.MetricType.DELETE_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_FAILED_SIZE; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; +import java.util.Properties; + +import org.apache.phoenix.end2end.index.ImmutableIndexIT; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@Category(NeedsOwnMiniClusterTest.class) +@RunWith(Parameterized.class) +public class MutationBatchFailedStateMetricIT extends ParallelStatsDisabledIT { + + String create_table = + "CREATE TABLE IF NOT EXISTS %s(ID VARCHAR NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER)"; + String indexName = generateUniqueName(); + String create_index = "CREATE INDEX " + indexName + " ON %s(VAL1 DESC) INCLUDE (VAL2)"; + String upsertStatement = "UPSERT INTO %s VALUES(?, ?, ?)"; + String deleteTableName = generateUniqueName(); + private final boolean transactional; + + public MutationBatchFailedStateMetricIT(String transactionProvider) { + this.transactional = transactionProvider != null; + if (this.transactional) { + create_table = + create_table + (this.transactional + ? (" TRANSACTIONAL=true,TRANSACTION_PROVIDER='" + transactionProvider + + "'") + : ""); + } + createTables(); + populateTables(); + } + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(3); + serverProps.put("hbase.coprocessor.abortonerror", "false"); + serverProps.put(Indexer.CHECK_VERSION_CONF_KEY, "false"); + Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(2); + clientProps.put(QueryServices.COLLECT_REQUEST_LEVEL_METRICS, String.valueOf(true)); + clientProps.put(QueryServices.TRANSACTIONS_ENABLED, "true"); + setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), + new ReadOnlyProps(clientProps.entrySet().iterator())); + + } + + @Parameterized.Parameters(name = "MutationBatchFailedStateMetricIT_transactionProvider={0}") + public static synchronized Collection<Object[]> data() { + return Arrays.asList(new Object[][] { { "OMID" }, { null } }); + } + + /** + * We will have 5 rows in table and we will try deleting 4 out of 5 rows + * In this test intention is to fail the delete and see how metric value is updated when that happens + * for transactional table and non transactional table + * @throws SQLException + */ + @Test + public void testFailedDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + + throw new AssertionError("Commit should not have succeeded"); + } catch (SQLException e) { + Map<String, Map<MetricType, Long>> mutationMetrics = + conn.unwrap(PhoenixConnection.class).getMutationMetrics(); + int mfs = + mutationMetrics.get(deleteTableName).get(MUTATION_BATCH_FAILED_SIZE).intValue(); + int dbfs = + mutationMetrics.get(deleteTableName).get(DELETE_BATCH_FAILED_SIZE).intValue(); + if (transactional) { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } else { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } + } + } + + @Test + public void testFailedUpsertAndDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + + String upsertSQL = String.format(upsertStatement,deleteTableName); + PreparedStatement preparedStatement = conn.prepareStatement(upsertSQL); + preparedStatement.setString(1, "ROW_6"); + preparedStatement.setInt(2, 6); + preparedStatement.setInt(3, 12); + preparedStatement.execute(); + + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + + throw new AssertionError("Commit should not have succeeded"); + } catch (SQLException e) { + Map<String, Map<MetricType, Long>> mutationMetrics = + conn.unwrap(PhoenixConnection.class).getMutationMetrics(); + int mfs = + mutationMetrics.get(deleteTableName).get(MUTATION_BATCH_FAILED_SIZE).intValue(); + int dbfs = + mutationMetrics.get(deleteTableName).get(DELETE_BATCH_FAILED_SIZE).intValue(); + if (transactional) { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(5, mfs); + } else { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(5, mfs); + } Review Comment: We no longer need if/else ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationBatchFailedStateMetricIT.java: ########## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.monitoring.MetricType.DELETE_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_FAILED_SIZE; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; +import java.util.Properties; + +import org.apache.phoenix.end2end.index.ImmutableIndexIT; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@Category(NeedsOwnMiniClusterTest.class) +@RunWith(Parameterized.class) +public class MutationBatchFailedStateMetricIT extends ParallelStatsDisabledIT { + + String create_table = + "CREATE TABLE IF NOT EXISTS %s(ID VARCHAR NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER)"; + String indexName = generateUniqueName(); + String create_index = "CREATE INDEX " + indexName + " ON %s(VAL1 DESC) INCLUDE (VAL2)"; + String upsertStatement = "UPSERT INTO %s VALUES(?, ?, ?)"; + String deleteTableName = generateUniqueName(); + private final boolean transactional; + + public MutationBatchFailedStateMetricIT(String transactionProvider) { + this.transactional = transactionProvider != null; + if (this.transactional) { + create_table = + create_table + (this.transactional + ? (" TRANSACTIONAL=true,TRANSACTION_PROVIDER='" + transactionProvider + + "'") + : ""); + } + createTables(); + populateTables(); + } + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(3); + serverProps.put("hbase.coprocessor.abortonerror", "false"); + serverProps.put(Indexer.CHECK_VERSION_CONF_KEY, "false"); + Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(2); + clientProps.put(QueryServices.COLLECT_REQUEST_LEVEL_METRICS, String.valueOf(true)); + clientProps.put(QueryServices.TRANSACTIONS_ENABLED, "true"); + setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), + new ReadOnlyProps(clientProps.entrySet().iterator())); + + } + + @Parameterized.Parameters(name = "MutationBatchFailedStateMetricIT_transactionProvider={0}") + public static synchronized Collection<Object[]> data() { + return Arrays.asList(new Object[][] { { "OMID" }, { null } }); + } + + /** + * We will have 5 rows in table and we will try deleting 4 out of 5 rows + * In this test intention is to fail the delete and see how metric value is updated when that happens + * for transactional table and non transactional table + * @throws SQLException + */ + @Test + public void testFailedDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + + throw new AssertionError("Commit should not have succeeded"); + } catch (SQLException e) { + Map<String, Map<MetricType, Long>> mutationMetrics = + conn.unwrap(PhoenixConnection.class).getMutationMetrics(); + int mfs = + mutationMetrics.get(deleteTableName).get(MUTATION_BATCH_FAILED_SIZE).intValue(); + int dbfs = + mutationMetrics.get(deleteTableName).get(DELETE_BATCH_FAILED_SIZE).intValue(); + if (transactional) { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } else { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } + } + } + + @Test + public void testFailedUpsertAndDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + + String upsertSQL = String.format(upsertStatement,deleteTableName); + PreparedStatement preparedStatement = conn.prepareStatement(upsertSQL); + preparedStatement.setString(1, "ROW_6"); + preparedStatement.setInt(2, 6); + preparedStatement.setInt(3, 12); + preparedStatement.execute(); + + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); Review Comment: Same here ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationBatchFailedStateMetricIT.java: ########## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.monitoring.MetricType.DELETE_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_FAILED_SIZE; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; +import java.util.Properties; + +import org.apache.phoenix.end2end.index.ImmutableIndexIT; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@Category(NeedsOwnMiniClusterTest.class) +@RunWith(Parameterized.class) +public class MutationBatchFailedStateMetricIT extends ParallelStatsDisabledIT { + + String create_table = + "CREATE TABLE IF NOT EXISTS %s(ID VARCHAR NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER)"; + String indexName = generateUniqueName(); + String create_index = "CREATE INDEX " + indexName + " ON %s(VAL1 DESC) INCLUDE (VAL2)"; + String upsertStatement = "UPSERT INTO %s VALUES(?, ?, ?)"; + String deleteTableName = generateUniqueName(); + private final boolean transactional; + + public MutationBatchFailedStateMetricIT(String transactionProvider) { + this.transactional = transactionProvider != null; + if (this.transactional) { + create_table = + create_table + (this.transactional + ? (" TRANSACTIONAL=true,TRANSACTION_PROVIDER='" + transactionProvider + + "'") + : ""); + } + createTables(); + populateTables(); + } + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(3); + serverProps.put("hbase.coprocessor.abortonerror", "false"); + serverProps.put(Indexer.CHECK_VERSION_CONF_KEY, "false"); + Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(2); + clientProps.put(QueryServices.COLLECT_REQUEST_LEVEL_METRICS, String.valueOf(true)); + clientProps.put(QueryServices.TRANSACTIONS_ENABLED, "true"); + setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), + new ReadOnlyProps(clientProps.entrySet().iterator())); + + } + + @Parameterized.Parameters(name = "MutationBatchFailedStateMetricIT_transactionProvider={0}") + public static synchronized Collection<Object[]> data() { + return Arrays.asList(new Object[][] { { "OMID" }, { null } }); + } + + /** + * We will have 5 rows in table and we will try deleting 4 out of 5 rows + * In this test intention is to fail the delete and see how metric value is updated when that happens + * for transactional table and non transactional table + * @throws SQLException + */ + @Test + public void testFailedDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); Review Comment: We can remove this as it will not likely be executed for successful test scenario. ########## phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java: ########## @@ -1572,12 +1572,19 @@ public static MutationMetricQueue.MutationMetric updateMutationBatchFailureMetri numDeleteMutationsInBatch++; } } + + long totalfailedMutation = numUpsertMutationsInBatch + numDeleteMutationsInBatch; + //TODO this case is something that should not happen + // but still if connditioon makes sese if this ever happens + if (totalfailedMutation < numFailedMutations) { + totalfailedMutation = numFailedMutations; + } Review Comment: As per this comment, we will likely not hit the case where `totalfailedMutation < numFailedMutations`? ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationBatchFailedStateMetricIT.java: ########## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + +import static org.apache.phoenix.monitoring.MetricType.DELETE_BATCH_FAILED_SIZE; +import static org.apache.phoenix.monitoring.MetricType.MUTATION_BATCH_FAILED_SIZE; +import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Arrays; +import java.util.Collection; +import java.util.Map; +import java.util.Properties; + +import org.apache.phoenix.end2end.index.ImmutableIndexIT; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.monitoring.MetricType; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.thirdparty.com.google.common.collect.Maps; +import org.apache.phoenix.util.PropertiesUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; + +@Category(NeedsOwnMiniClusterTest.class) +@RunWith(Parameterized.class) +public class MutationBatchFailedStateMetricIT extends ParallelStatsDisabledIT { + + String create_table = + "CREATE TABLE IF NOT EXISTS %s(ID VARCHAR NOT NULL PRIMARY KEY, VAL1 INTEGER, VAL2 INTEGER)"; + String indexName = generateUniqueName(); + String create_index = "CREATE INDEX " + indexName + " ON %s(VAL1 DESC) INCLUDE (VAL2)"; + String upsertStatement = "UPSERT INTO %s VALUES(?, ?, ?)"; + String deleteTableName = generateUniqueName(); + private final boolean transactional; + + public MutationBatchFailedStateMetricIT(String transactionProvider) { + this.transactional = transactionProvider != null; + if (this.transactional) { + create_table = + create_table + (this.transactional + ? (" TRANSACTIONAL=true,TRANSACTION_PROVIDER='" + transactionProvider + + "'") + : ""); + } + createTables(); + populateTables(); + } + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(3); + serverProps.put("hbase.coprocessor.abortonerror", "false"); + serverProps.put(Indexer.CHECK_VERSION_CONF_KEY, "false"); + Map<String, String> clientProps = Maps.newHashMapWithExpectedSize(2); + clientProps.put(QueryServices.COLLECT_REQUEST_LEVEL_METRICS, String.valueOf(true)); + clientProps.put(QueryServices.TRANSACTIONS_ENABLED, "true"); + setUpTestDriver(new ReadOnlyProps(serverProps.entrySet().iterator()), + new ReadOnlyProps(clientProps.entrySet().iterator())); + + } + + @Parameterized.Parameters(name = "MutationBatchFailedStateMetricIT_transactionProvider={0}") + public static synchronized Collection<Object[]> data() { + return Arrays.asList(new Object[][] { { "OMID" }, { null } }); + } + + /** + * We will have 5 rows in table and we will try deleting 4 out of 5 rows + * In this test intention is to fail the delete and see how metric value is updated when that happens + * for transactional table and non transactional table + * @throws SQLException + */ + @Test + public void testFailedDelete() throws Exception { + Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES); + Connection conn = null; + try { + conn = DriverManager.getConnection(getUrl(), props); + + Statement stmt = conn.createStatement(); + // adding coprocessor which basically overrides prebatchmutate whiich is called for all + // the mutations + // it is called before applying mutation to region + TestUtil.addCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + // trying to delete 4 rows with this single delete statement + String dml = String.format("DELETE FROM %s where val1 > 1", deleteTableName); + stmt.execute(dml); + conn.commit(); + + TestUtil.removeCoprocessor(conn, deleteTableName, + ImmutableIndexIT.DeleteFailingRegionObserver.class); + + throw new AssertionError("Commit should not have succeeded"); + } catch (SQLException e) { + Map<String, Map<MetricType, Long>> mutationMetrics = + conn.unwrap(PhoenixConnection.class).getMutationMetrics(); + int mfs = + mutationMetrics.get(deleteTableName).get(MUTATION_BATCH_FAILED_SIZE).intValue(); + int dbfs = + mutationMetrics.get(deleteTableName).get(DELETE_BATCH_FAILED_SIZE).intValue(); + if (transactional) { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } else { + Assert.assertEquals(4, dbfs); + Assert.assertEquals(4, mfs); + } Review Comment: Same as above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
