tkhurana commented on code in PR #1546:
URL: https://github.com/apache/phoenix/pull/1546#discussion_r1065226588
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1214,6 +1216,8 @@ private void sendBatch(Map<TableRef,
MultiRowMutationState> commitBatch, long[]
serverTimeStamps == null ?
validateAndGetServerTimestamp(tableRef,
multiRowMutationState) :
serverTimeStamps[i++];
+ long syscatTime = EnvironmentEdgeManager.currentTimeMillis() -
startTime;
Review Comment:
Also, this is being called in a loop so you need to reset the value of
startTime for every iteration.
##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1214,6 +1216,8 @@ private void sendBatch(Map<TableRef,
MultiRowMutationState> commitBatch, long[]
serverTimeStamps == null ?
validateAndGetServerTimestamp(tableRef,
multiRowMutationState) :
serverTimeStamps[i++];
+ long syscatTime = EnvironmentEdgeManager.currentTimeMillis() -
startTime;
Review Comment:
@mnpoonia This is not the only place where we call
validateAndGetServerTimestamp. It is also called from here
https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java#L895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
