mnpoonia commented on code in PR #1541:
URL: https://github.com/apache/phoenix/pull/1541#discussion_r1065299319


##########
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1572,12 +1572,19 @@ public static MutationMetricQueue.MutationMetric 
updateMutationBatchFailureMetri
                 numDeleteMutationsInBatch++;
             }
         }
+
+        long totalfailedMutation = numUpsertMutationsInBatch + 
numDeleteMutationsInBatch;
+        //TODO this case is something that should not happen
+        // but still if connditioon makes sese if this ever happens
+        if (totalfailedMutation < numFailedMutations) {
+            totalfailedMutation = numFailedMutations;
+        }

Review Comment:
   Added warning log there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to