[
https://issues.apache.org/jira/browse/PHOENIX-6786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657016#comment-17657016
]
Andrew Kyle Purtell edited comment on PHOENIX-6786 at 1/11/23 12:10 AM:
------------------------------------------------------------------------
apurtell commented on PR #1549:
URL: https://github.com/apache/phoenix/pull/1549#issuecomment-1378059506
@kadirozde Is this the kind of refactoring you had in mind?
This patch:
- Adds a preBatchMutate hook to SequenceRegionObserver that will filter any
Append or Increment operations submitted in batch and handle them ahead of base
HBase processing. Puts and Deletes will be passed through to normal handling as
required. Phoenix rewrites Increment into Puts and submits them by
Region#batchMutate, which would set up a cycle with preBatchMutate otherwise, I
believe.
- Retains existing hooks for preAppend and preIncrement that are necessary
for intercepting other APIs.
- Refactor most logic to reusable private methods.
was (Author: githubbot):
apurtell commented on PR #1549:
URL: https://github.com/apache/phoenix/pull/1549#issuecomment-1378059506
@kadirozde Is this the kind of refactoring you had in mind?
This patch:
- Adds a preBatchMutate hook that will filter any Append or Increment
operations submitted in batch and handle them ahead of base HBase processing.
- Retains existing hooks for preAppend and preIncrement that are necessary
for intercepting other APIs.
- Refactor most logic to reusable private methods.
> SequenceRegionObserver should use batch mutation coproc hooks
> -------------------------------------------------------------
>
> Key: PHOENIX-6786
> URL: https://issues.apache.org/jira/browse/PHOENIX-6786
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Andrew Kyle Purtell
> Priority: Major
>
> SequenceRegionObserver uses preIncrement but could use the standard batch
> mutation coproc hooks, similarly to how atomic upserts work after
> PHOENIX-6387. This will simplify the code and also make it easier to re-use
> code from secondary index generation in performance optimizations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
