tkhurana commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1101829246
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -502,9 +503,10 @@ private void
populateRowsToLock(MiniBatchOperationInProgress<Mutation> miniBatch
Mutation m = miniBatchOp.getOperation(i);
if (this.builder.isAtomicOp(m) || this.builder.isEnabled(m)) {
ImmutableBytesPtr row = new ImmutableBytesPtr(m.getRow());
- if (!context.rowsToLock.contains(row)) {
+// This seems to be unnecessary as we are using a set here
+// if (!context.rowsToLock.contains(row)) {
Review Comment:
Thanks @mnpoonia . Looks good. Please remove the comments as suggested by
@gourabtaparia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
