gjacoby126 commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1102958695
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The collection of candidate index mutations that will be applied
after the data table mutations
private ListMultimap<HTableInterfaceReference, Pair<Mutation, byte[]>>
indexUpdates;
private List<RowLock> rowLocks =
Lists.newArrayListWithExpectedSize(QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);
- private HashSet<ImmutableBytesPtr> rowsToLock = new HashSet<>();
+ private Set<ImmutableBytesPtr> rowsToLock = new TreeSet<>();
Review Comment:
@mnpoonia I see we're not specifying a sort order here, just using the
default for ImmutableBytesPtr.
To make sure I understand correctly:
It only matters that all threads use a _consistent_ sort order to acquire
locks, not that that consistent order matches any particular order (such as the
HBase row key comparator), correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
