mnpoonia commented on code in PR #1559:
URL: https://github.com/apache/phoenix/pull/1559#discussion_r1104605952
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -227,7 +228,7 @@ public static class BatchMutateContext {
// The collection of candidate index mutations that will be applied
after the data table mutations
private ListMultimap<HTableInterfaceReference, Pair<Mutation, byte[]>>
indexUpdates;
private List<RowLock> rowLocks =
Lists.newArrayListWithExpectedSize(QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);
- private HashSet<ImmutableBytesPtr> rowsToLock = new HashSet<>();
+ private Set<ImmutableBytesPtr> rowsToLock = new TreeSet<>();
Review Comment:
>It only matters that all threads use a consistent sort order to acquire
locks, not that that consistent order matches any particular order (such as the
HBase row key comparator), correct?
That is right.
>Also, it would be good to put a comment above the TreeSet constructor
Done
@virajjasani @gjacoby126 FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
