stoty commented on code in PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#discussion_r1121843444
##########
tso-server/src/main/java/org/apache/omid/tso/TSOChannelHandler.java:
##########
@@ -49,8 +49,13 @@
import io.netty.handler.codec.LengthFieldPrepender;
import io.netty.handler.codec.protobuf.ProtobufDecoder;
import io.netty.handler.codec.protobuf.ProtobufEncoder;
+import io.netty.handler.ssl.OptionalSslHandler;
+import io.netty.handler.ssl.SslContext;
import io.netty.util.AttributeKey;
import io.netty.util.concurrent.GlobalEventExecutor;
+import org.apache.omid.tls.X509Util;
+import org.apache.zookeeper.common.X509Exception;
Review Comment:
Please make copy of this Exception.
##########
common/pom.xml:
##########
@@ -104,6 +104,41 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>${zookeeper.version}</version>
+ </dependency>
+
+ <dependency>
Review Comment:
Shouldn't this be test scope ?
##########
common/pom.xml:
##########
@@ -104,6 +104,41 @@
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
As I said elsewhere, we should copy the exceptions, so we shouldn't depend
on ZK here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
