stoty commented on code in PR #1571:
URL: https://github.com/apache/phoenix/pull/1571#discussion_r1143775850
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/types/PBoolean.java:
##########
@@ -85,6 +86,19 @@ public Boolean toObject(byte[] bytes, int offset, int
length, PDataType actualTy
return null;
}
+ @Override
+ public Object toObject(byte[] bytes, int offset, int length, PDataType
actualType,
+ SortOrder sortOrder, Integer maxLength, Integer scale, Class
jdbcType)
+ throws SQLException {
+ // FIXME according to the JDBC spec, we should support all these types:
Review Comment:
Opened PHOENIX-6915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
