stoty commented on code in PR #124:
URL:
https://github.com/apache/phoenix-queryserver/pull/124#discussion_r1153711967
##########
python-phoenixdb/phoenixdb/cursor.py:
##########
@@ -115,6 +115,7 @@ def description(self):
description = []
for column in self._signature.columns:
description.append(ColumnDescription(
+ column.label,
Review Comment:
Replace column_name, instead of adding a new element.
##########
python-phoenixdb/gen-protobuf.sh:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
set -x
-AVATICA_VER=1.21.0
+AVATICA_VER=1.23.0
Review Comment:
no need to rebuild protobuf, there have been no changes.
##########
python-phoenixdb/.gitignore:
##########
@@ -8,6 +8,5 @@
.tox
dev-support/artifacts
dev-support/work
-phoenixdb/.eggs
-phoenixdb/build
-phoenixdb/e
+.eggs
Review Comment:
keep the old entries instead of replacing, some build scenarios may generate
files there
##########
python-phoenixdb/phoenixdb/cursor.py:
##########
@@ -27,7 +27,7 @@
# TODO see note in Cursor.rowcount()
MAX_INT = 2 ** 64 - 1
-ColumnDescription = collections.namedtuple('ColumnDescription', 'name
type_code display_size internal_size precision scale null_ok')
+ColumnDescription = collections.namedtuple('ColumnDescription', 'label name
type_code display_size internal_size precision scale null_ok')
Review Comment:
According to
https://peps.python.org/pep-0249/#description
This must have exactly 7 elements, not 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
