[
https://issues.apache.org/jira/browse/PHOENIX-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707014#comment-17707014
]
ASF GitHub Bot commented on PHOENIX-6917:
-----------------------------------------
stoty commented on code in PR #124:
URL:
https://github.com/apache/phoenix-queryserver/pull/124#discussion_r1153711967
##########
python-phoenixdb/phoenixdb/cursor.py:
##########
@@ -115,6 +115,7 @@ def description(self):
description = []
for column in self._signature.columns:
description.append(ColumnDescription(
+ column.label,
Review Comment:
Replace column_name, instead of adding a new element.
##########
python-phoenixdb/gen-protobuf.sh:
##########
@@ -16,7 +16,7 @@
# limitations under the License.
set -x
-AVATICA_VER=1.21.0
+AVATICA_VER=1.23.0
Review Comment:
no need to rebuild protobuf, there have been no changes.
##########
python-phoenixdb/.gitignore:
##########
@@ -8,6 +8,5 @@
.tox
dev-support/artifacts
dev-support/work
-phoenixdb/.eggs
-phoenixdb/build
-phoenixdb/e
+.eggs
Review Comment:
keep the old entries instead of replacing, some build scenarios may generate
files there
##########
python-phoenixdb/phoenixdb/cursor.py:
##########
@@ -27,7 +27,7 @@
# TODO see note in Cursor.rowcount()
MAX_INT = 2 ** 64 - 1
-ColumnDescription = collections.namedtuple('ColumnDescription', 'name
type_code display_size internal_size precision scale null_ok')
+ColumnDescription = collections.namedtuple('ColumnDescription', 'label name
type_code display_size internal_size precision scale null_ok')
Review Comment:
According to
https://peps.python.org/pep-0249/#description
This must have exactly 7 elements, not 8.
> Column alias not working properly
> ---------------------------------
>
> Key: PHOENIX-6917
> URL: https://issues.apache.org/jira/browse/PHOENIX-6917
> Project: Phoenix
> Issue Type: Bug
> Components: python, queryserver
> Affects Versions: python-phoenixdb-1.2.1
> Reporter: Satya Kommula
> Priority: Major
> Fix For: python-phoenixdb-1.2.2
>
>
> Get the columnLabel (the “as name”) rather than the columnName with a cursor.
> {code:java}
> calcite 💎:sql> select c1 as hello, c2 as world from int_tbl;
> +-------------+-------------+
> | c1 | c2 |
> |-------------+-------------|
> | 5 | 0 |
> | -123 | 123 |
> | 1 | 123456 |
> | -123456 | -123456 |
> | 10 | 50 |
> | -2147483648 | 1 |
> | 2147483647 | -2147483648 |
> | <null> | 10 |
> | <null> | <null> |
> | 1 | 1 |
> +-------------+-------------+{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
