kadirozde commented on code in PR #1569: URL: https://github.com/apache/phoenix/pull/1569#discussion_r1157909438
########## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TTLRegionScanner.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.coprocessor; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; + +import org.apache.hadoop.hbase.Cell; +import org.apache.hadoop.hbase.CellUtil; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment; +import org.apache.hadoop.hbase.filter.PageFilter; +import org.apache.hadoop.hbase.regionserver.RegionScanner; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.query.QueryServicesOptions; +import org.apache.phoenix.util.EnvironmentEdgeManager; +import org.apache.phoenix.util.ScanUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_FAMILY_NAME; +import static org.apache.phoenix.coprocessor.BaseScannerRegionObserver.EMPTY_COLUMN_QUALIFIER_NAME; + +/** + * TTLRegionScanner masks expired rows using the empty column cell timestamp + */ +public class TTLRegionScanner extends BaseRegionScanner { + private static final Logger LOG = + LoggerFactory.getLogger(TTLRegionScanner.class); + private final boolean isMaskingEnabled; + private final RegionCoprocessorEnvironment env; + private Scan scan; + private long rowCount = 0; + private long pageSize = Long.MAX_VALUE; + long ttl; + long ttlWindowStart; + byte[] emptyCQ; + byte[] emptyCF; + private boolean initialized = false; + + public TTLRegionScanner(final RegionCoprocessorEnvironment env, final Scan scan, + final RegionScanner s) { + super(s); + this.env = env; + this.scan = scan; + emptyCQ = scan.getAttribute(EMPTY_COLUMN_QUALIFIER_NAME); + emptyCF = scan.getAttribute(EMPTY_COLUMN_FAMILY_NAME); + long currentTime = EnvironmentEdgeManager.currentTimeMillis(); + ttl = env.getRegion().getTableDescriptor().getColumnFamilies()[0].getTimeToLive(); + ttlWindowStart = ttl == HConstants.FOREVER ? 1 : currentTime - ttl * 1000; + ttl *= 1000; + // Regardless if the Phoenix Table TTL feature is disabled cluster wide or the client is + // an older client and does not supply the empty column parameters, the masking should not + // be done here. + isMaskingEnabled = emptyCF != null && emptyCQ != null && + env.getConfiguration().getBoolean(QueryServices.PHOENIX_TABLE_TTL_ENABLED, + QueryServicesOptions.DEFAULT_PHOENIX_TABLE_TTL_ENABLED); + } + + private void init() throws IOException { + // HBase PageFilter will also count the expired rows. + // Instead of using PageFilter for counting, we will count returned row here. + PageFilter pageFilter = ScanUtil.removePageFilter(scan); Review Comment: PageFilter is an HBase builtin filter. The name should have been LimitFilter instead of PageFilter. So, there is no relation between the server paging feature and PageFilter. Phoenix has PagingRegionScanner and PagingFilter. I know it is confusing. The code is simpler when we count always. Adding an if statement and counting only when the PageFilter is removed is not more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
