[
https://issues.apache.org/jira/browse/PHOENIX-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712583#comment-17712583
]
ASF GitHub Bot commented on PHOENIX-6918:
-----------------------------------------
lokiore commented on PR #1589:
URL: https://github.com/apache/phoenix/pull/1589#issuecomment-1509403243
@gjacoby126, addressed the nits.
Thanks for reviewing !
> ScanningResultIterator should not retry when the query times out
> ----------------------------------------------------------------
>
> Key: PHOENIX-6918
> URL: https://issues.apache.org/jira/browse/PHOENIX-6918
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Kadir Ozdemir
> Assignee: Lokesh Khurana
> Priority: Major
>
> ScanningResultIterator drops dummy results and retries Result#next() in a
> loop as part of the Phoenix server paging feature.
> ScanningResultIterator does not check if the query has already timed out
> currently. This means that ScanningResultIterator let the server to work on
> the scan even though the Phoenix query is already timed out.
> ScanningResultIterator should check if the query of the scan has been timed
> out and if so should return an operation timeout exception as
> BaseResultIterators does.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
