tkhurana commented on code in PR #1619:
URL: https://github.com/apache/phoenix/pull/1619#discussion_r1224545078
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java:
##########
@@ -872,6 +887,12 @@ public QueryPlan getQueryPlan() {
}
}
+ /**
+ * Implementation of MutationPlan that is selected if
+ * 1) there are immutable indexes presented for the table,
+ * 2) the query has WHERE clause and is not strictly point lookup, and
Review Comment:
I think just bullet point 3 is good enough. From the code we give preference
to server side delete and only if the query doesn't match the criteria of
server side delete we fallback to client side delete. So any of the conditions
where server side delete is not selected will result in client delete plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
