[
https://issues.apache.org/jira/browse/PHOENIX-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743057#comment-17743057
]
ASF GitHub Bot commented on PHOENIX-6986:
-----------------------------------------
stoty commented on code in PR #1640:
URL: https://github.com/apache/phoenix/pull/1640#discussion_r1263487600
##########
phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java:
##########
@@ -336,10 +336,15 @@ private QueryPlan addPlan(PhoenixStatement statement,
SelectStatement select, PT
Map<TableRef, QueryPlan> dataPlans =
Collections.singletonMap(indexTableRef, dataPlan);
PTable indexTable = indexTableRef.getTable();
PIndexState indexState = indexTable.getIndexState();
+ boolean isServerMergeFoeUncoveredIndexEnabled =
statement.getConnection().
Review Comment:
typo
##########
phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java:
##########
@@ -336,10 +336,15 @@ private QueryPlan addPlan(PhoenixStatement statement,
SelectStatement select, PT
Map<TableRef, QueryPlan> dataPlans =
Collections.singletonMap(indexTableRef, dataPlan);
PTable indexTable = indexTableRef.getTable();
PIndexState indexState = indexTable.getIndexState();
+ boolean isServerMergeFoeUncoveredIndexEnabled =
statement.getConnection().
Review Comment:
Also, CQSI is already available in the "services" object variable, no need
to go back to statement.
> Add property to disable server merges for hinted uncovered indexes
> ------------------------------------------------------------------
>
> Key: PHOENIX-6986
> URL: https://issues.apache.org/jira/browse/PHOENIX-6986
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Istvan Toth
> Priority: Major
>
> The new server merge query plan can perform worse than the old skip-join-scan
> plan.
> Add a property to completely disable it.
> This should help with migrating workloads to the new version, without having
> to verify if server merge performs well, and having add hints to disable it
> where needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
