stoty commented on code in PR #1607: URL: https://github.com/apache/phoenix/pull/1607#discussion_r1268995942
########## phoenix-core/src/main/java/org/apache/phoenix/iterate/ParallelScansCollector.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.iterate; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.hadoop.hbase.client.Scan; +import org.apache.phoenix.compile.QueryPlan; + +/** + * Stores some state to help build the parallel Scans structure + */ +public class ParallelScansCollector { + + private ParallelScanGrouper grouper; + private boolean lastScanCrossedRegionBoundary = false; + private List<List<Scan>> parallelScans = new ArrayList<>(); + private List<Scan> lastBatch = new ArrayList<>(); Review Comment: Will fix in a moment ########## phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java: ########## @@ -155,6 +155,7 @@ public static Expression pushKeyExpressionsToScan(StatementContext context, Set< keySlots = whereClause.accept(visitor); if (keySlots == null && (tenantId == null || !table.isMultiTenant()) && table.getViewIndexId() == null && !minOffset.isPresent()) { + // FIXME this overwrites salting info in the scanRange Review Comment: None. If this were fixed, we could take use the salting info from the scanRange object. Now, we have to go back to the PTable to get it, and the salting info in ScanRange is not used. ########## phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java: ########## @@ -155,6 +155,7 @@ public static Expression pushKeyExpressionsToScan(StatementContext context, Set< keySlots = whereClause.accept(visitor); if (keySlots == null && (tenantId == null || !table.isMultiTenant()) && table.getViewIndexId() == null && !minOffset.isPresent()) { + // FIXME this overwrites salting info in the scanRange Review Comment: Currently none. We just need to re-read some salting info from the table, instead of taking the cached value from -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
