stoty commented on code in PR #1656:
URL: https://github.com/apache/phoenix/pull/1656#discussion_r1299636488
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexCoprocIT.java:
##########
@@ -58,12 +58,12 @@ public class IndexCoprocIT extends ParallelStatsDisabledIT {
"|org.apache.phoenix.index.GlobalIndexChecker|805306365|";
public static final String INDEX_REGION_OBSERVER_CONFIG =
"|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|" +
- "index.builder=org.apache.phoenix.index.PhoenixIndexBuilder," +
Review Comment:
Can you revert the whitespace changes ?
If we don't change these, it's better to leave the file alone.
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java:
##########
@@ -194,7 +194,6 @@ public BatchMutateContext(int clientVersion) {
.encodeVersion("0.94.9");
private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000;
-
Review Comment:
nit: don't delete the empty line
##########
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java:
##########
@@ -333,7 +330,6 @@ public int getMaxPendingRowCount() {
private static final int DEFAULT_ROWLOCK_WAIT_DURATION = 30000;
private static final int DEFAULT_CONCURRENT_MUTATION_WAIT_DURATION_IN_MS =
100;
-
Review Comment:
nit: don't delete the empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
