lokiore commented on code in PR #1669: URL: https://github.com/apache/phoenix/pull/1669#discussion_r1318943145
########## phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java: ########## @@ -55,15 +55,8 @@ import org.apache.phoenix.parse.SelectStatement; import org.apache.phoenix.parse.TableName; import org.apache.phoenix.query.QueryConstants; -import org.apache.phoenix.schema.ColumnRef; -import org.apache.phoenix.schema.MetaDataClient; -import org.apache.phoenix.schema.PDatum; -import org.apache.phoenix.schema.PName; -import org.apache.phoenix.schema.PTable; +import org.apache.phoenix.schema.*; Review Comment: Can we revert changes in this file as they are not needed!? ########## phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java: ########## @@ -56,9 +56,7 @@ import org.apache.phoenix.jdbc.PhoenixStatement; import org.apache.phoenix.query.KeyRange; import org.apache.phoenix.query.QueryServices; -import org.apache.phoenix.schema.PTable; -import org.apache.phoenix.schema.PTableImpl; -import org.apache.phoenix.schema.ReadOnlyTableException; +import org.apache.phoenix.schema.*; Review Comment: Please remove * import! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
