palashc commented on code in PR #1666:
URL: https://github.com/apache/phoenix/pull/1666#discussion_r1325219999


##########
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -417,11 +504,22 @@ private PhoenixResultSet executeQuery(final 
CompilableStatement stmt,
                                                     e.getSchemaName(), 
e.getTableName(), true)
                                             .wasUpdated()) {
                                         //TODO we can log retry count and 
error for debugging in LOG table
-                                        return executeQuery(stmt, false, 
queryLogger, noCommit);
+                                        return executeQuery(stmt, false, 
queryLogger, noCommit, validateDDLTimestamp);
                                     }
                                 }
                                 throw e;
-                            } catch (RuntimeException e) {
+                            }
+                            catch (SQLException e) {
+                                // force update cache in case of 
StaleMetadataCacheException and retry

Review Comment:
   As discussed, validateDDLTimestamp retry is just for the RPC call. This 
retry is for executeQuery() after force-updating the client cache. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to