lokiore commented on code in PR #1660:
URL: https://github.com/apache/phoenix/pull/1660#discussion_r1327863767
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -5480,21 +5522,21 @@ private boolean evaluateStmtProperties(MetaProperties
metaProperties, MetaProper
}
}
- if (metaProperties.getPhoenixTTL() != null) {
+ if (metaProperties.getTTL() != null) {
if (table.getType() == PTableType.INDEX) {
throw new SQLExceptionInfo.Builder(
SQLExceptionCode.CANNOT_SET_OR_ALTER_PROPERTY_FOR_INDEX)
.build()
.buildException();
}
- if (table.getType() != PTableType.TABLE && table.getType() !=
SYSTEM) {
+ if (table.getType() != PTableType.TABLE) {
Review Comment:
Yes, for SYSTEM table TTL is not supported at Phoenix level as discussed I
am not sure why this change is shown by git as this is already there :-
https://github.com/apache/phoenix/blame/40a30ac66a7655003f52e816525c3e209d44a083/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java#L2065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
