[
https://issues.apache.org/jira/browse/PHOENIX-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768593#comment-17768593
]
ASF GitHub Bot commented on PHOENIX-6633:
-----------------------------------------
stoty commented on PR #108:
URL:
https://github.com/apache/phoenix-connectors/pull/108#issuecomment-1733197656
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 46s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 10m 52s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 37s | master passed |
| +1 :green_heart: | compile | 1m 26s | master passed |
| +1 :green_heart: | checkstyle | 0m 20s | master passed |
| +1 :green_heart: | javadoc | 0m 31s | master passed |
| +0 :ok: | spotbugs | 0m 50s | phoenix5-spark in master has 40 extant
spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 40s | phoenix5-spark3 in master has 22 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 44s | the patch passed |
| +1 :green_heart: | compile | 1m 26s | the patch passed |
| -1 :x: | javac | 0m 29s | phoenix5-spark generated 54 new + 105
unchanged - 46 fixed = 159 total (was 151) |
| -1 :x: | javac | 0m 29s | phoenix5-spark3 generated 48 new + 141
unchanged - 45 fixed = 189 total (was 186) |
| -1 :x: | checkstyle | 0m 8s | phoenix5-spark: The patch generated 12
new + 74 unchanged - 4 fixed = 86 total (was 78) |
| -1 :x: | checkstyle | 0m 8s | phoenix5-spark3: The patch generated 6
new + 86 unchanged - 3 fixed = 92 total (was 89) |
| -1 :x: | markdownlint | 0m 2s | The patch generated 14 new + 92
unchanged - 13 fixed = 106 total (was 105) |
| -1 :x: | whitespace | 0m 0s | The patch has 6 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 :x: | javadoc | 0m 11s | phoenix5-spark generated 9 new + 155
unchanged - 1 fixed = 164 total (was 156) |
| -1 :x: | javadoc | 0m 11s | phoenix5-spark3 generated 6 new + 188
unchanged - 3 fixed = 194 total (was 191) |
| +1 :green_heart: | spotbugs | 1m 40s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 45s | phoenix5-spark in the patch
passed. |
| +1 :green_heart: | unit | 0m 39s | phoenix5-spark3 in the patch
passed. |
| +1 :green_heart: | unit | 25m 2s | phoenix5-spark3-it in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate
ASF License warnings. |
| | | 66m 30s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/108 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile markdownlint |
| uname | Linux 8575f3bc1b0c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19
13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / ca76ff8 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-compile-javac-phoenix5-spark.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-compile-javac-phoenix5-spark3.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix5-spark3.txt
|
| markdownlint |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix5-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix5-spark3.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/testReport/
|
| Max. process+thread count | 1934 (vs. ulimit of 30000) |
| modules | C: phoenix5-spark phoenix5-spark3 phoenix5-spark3-it U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-108/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Use standard JDBC URL in Spark Connector and make it optional
> -------------------------------------------------------------
>
> Key: PHOENIX-6633
> URL: https://issues.apache.org/jira/browse/PHOENIX-6633
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> We require explicitly specifying the ZK URL for the Phoenix-Spark connector.
> Since having hbase-site.xml on the classpath is required by Phoenix anyway,
> we could use the quorum from hbase-site.xml as default, which would make life
> easier for users.
> Phoenix already handles this, we just need to remove the check, and adopt the
> JDBC URL not to specify the ZK quorum if missing.
> The current zkUrl code also acts as an aritificial limitation on using the
> new zookeeperless Hbase registries from Spark.
> We need to deprecate zkUrl, and add a new jdbcUrl property, which is simply
> passed to Phoenix without further processing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
