[
https://issues.apache.org/jira/browse/PHOENIX-7023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769295#comment-17769295
]
ASF GitHub Bot commented on PHOENIX-7023:
-----------------------------------------
jpisaac commented on code in PR #1688:
URL: https://github.com/apache/phoenix/pull/1688#discussion_r1337530891
##########
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -4135,17 +4145,15 @@ protected PhoenixConnection
upgradeSystemCatalogIfRequired(PhoenixConnection met
metaConnection = addColumnsIfNotExists(metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0 - 2,
PhoenixDatabaseMetaData.STREAMING_TOPIC_NAME + " " +
PVarchar.INSTANCE.getSqlTypeName());
- /**
- * TODO: Provide a path to copy existing data from PHOENIX_TTL to
TTL column and then
- * to DROP PHOENIX_TTL Column. See PHOENIX-7023
- */
- metaConnection = addColumnsIfNotExists(metaConnection,
- PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0 - 1,
+ metaConnection = addColumnsIfNotExists(metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
+ MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0 - 1,
PhoenixDatabaseMetaData.TTL + " " +
PInteger.INSTANCE.getSqlTypeName());
metaConnection = addColumnsIfNotExists(metaConnection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG,
MIN_SYSTEM_TABLE_TIMESTAMP_5_2_0,
- PhoenixDatabaseMetaData.ROW_KEY_PREFIX + " "
- + PVarbinary.INSTANCE.getSqlTypeName());
+ PhoenixDatabaseMetaData.ROW_KEY_PREFIX + " " +
+ PVarbinary.INSTANCE.getSqlTypeName());
+ //Copy Data From PHOENIX_TTL column to TTL and column will be
removed after copying.
Review Comment:
nit: removed in a future release
##########
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java:
##########
@@ -139,6 +139,7 @@ public MutationPlan compile(CreateTableStatement create)
throws SQLException {
if (whereNode == null) {
viewStatementToBe = parentToBe.getViewStatement();
} else {
+
Review Comment:
nit: whitespace changes
##########
phoenix-core/src/main/protobuf/PTable.proto:
##########
@@ -106,19 +106,16 @@ message PTable {
optional int32 viewIndexIdType = 39 [default = 5];
optional bool viewModifiedUpdateCacheFrequency = 40;
optional bool viewModifiedUseStatsForParallelization = 41;
- optional int64 phoenixTTL = 42;
Review Comment:
Let's not change the message format in this release. Maybe safer to remove
it in a later release when the columns are removed. We will need to ensure
backward and forward compatibility of messages against various versions of the
client and server.
> Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code
> ------------------------------------------------------------------
>
> Key: PHOENIX-7023
> URL: https://issues.apache.org/jira/browse/PHOENIX-7023
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Jacob Isaac
> Assignee: Lokesh Khurana
> Priority: Major
>
> Deprecate the old columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code
> since they are not compatible with the new
> [design|[https://docs.google.com/document/d/1D2B0G_sVe9eE66bk-sxUfSgoGtQCvD7xBZRxZz-Q1TM/edit]|https://docs.google.com/document/d/1D2B0G_sVe9eE66bk-sxUfSgoGtQCvD7xBZRxZz-Q1TM/edit].]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
