[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769516#comment-17769516
]
ASF GitHub Bot commented on PHOENIX-7038:
-----------------------------------------
ranganathg commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1338335686
##########
phoenix-core/src/test/java/org/apache/phoenix/monitoring/connqueryservice/PhoenixConnectionQueryServiceMetricsTest.java:
##########
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.monitoring.connqueryservice;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.phoenix.monitoring.MetricType;
+import org.apache.phoenix.monitoring.PhoenixConnectionProfileMetric;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+
+import static
org.apache.phoenix.monitoring.connqueryservice.ConnectionQueryServiceNameMetricsGenerateAndVerifyTestData.openInternalPhoenixConnCounter;
+import static
org.apache.phoenix.monitoring.connqueryservice.ConnectionQueryServiceNameMetricsGenerateAndVerifyTestData.openPhoenixConnCounter;
+import static
org.apache.phoenix.monitoring.connqueryservice.ConnectionQueryServiceNameMetricsGenerateAndVerifyTestData.connectionQueryServiceNames;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+public class PhoenixConnectionQueryServiceMetricsTest {
+ static Map<String, PhoenixConnectionQueryServiceMetrics>
phoxnixConnectionQueryServiceSet = new HashMap<>();
Review Comment:
nit:phoenixConnectionQueryServiceSet ?
> Implement Phoenix Connection Profile Metrics
> --------------------------------------------
>
> Key: PHOENIX-7038
> URL: https://issues.apache.org/jira/browse/PHOENIX-7038
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Mihir Monani
> Assignee: Mihir Monani
> Priority: Major
>
> With JDBC connection profile string, Clients can provide connection profile
> name. With use of Connection Profile, different kinds of clients/use-case in
> single JVM can create connection with different configuration like time-outs,
> retries, sleep between retries.
> Connection URL Example : jdbc:phoenix:localhost:2181:CONN_PROFILE_2
> Here CONN_PROFILE_2 is connection profile name.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
